Edward Betts
3c787b33d3
- Support any station with direct trains to Paddington; station CRS code is now part of the URL (/results/<crs>/<slug>/<date>) - Load station list from data/direct_to_paddington.tsv; show dropdown on index page; 404 for unknown station codes - Fetch live GWR walk-on fares via api.gwr.com for all stations (SSS/SVS/SDS with restrictions already applied per train); cache 30 days - Scrape Paddington arrival platform numbers from RTT - Show unreachable morning Eurostars (before first reachable service only) - Circle line: show actual KX St Pancras arrival times (not check-in estimate) and add a second backup service in the transfer column - Widen page max-width to 1100px for longer station names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
216 lines
9.5 KiB
Python
216 lines
9.5 KiB
Python
import app as app_module
|
||
|
||
|
||
def _client():
|
||
app_module.app.config['TESTING'] = True
|
||
return app_module.app.test_client()
|
||
|
||
|
||
def _stub_data(monkeypatch, prices=None, gwr_fares=None):
|
||
monkeypatch.setattr(app_module, 'get_cached', lambda key, ttl=None: None)
|
||
monkeypatch.setattr(app_module, 'set_cached', lambda key, data: None)
|
||
monkeypatch.setattr(
|
||
app_module.rtt_scraper,
|
||
'fetch',
|
||
lambda travel_date, user_agent, station_crs='BRI': [
|
||
{'depart_bristol': '07:00', 'arrive_paddington': '08:45', 'headcode': '1A23'},
|
||
],
|
||
)
|
||
monkeypatch.setattr(
|
||
app_module.gwr_fares_scraper,
|
||
'fetch',
|
||
lambda station_crs, travel_date: gwr_fares or {'07:00': {'ticket': 'Anytime Day Single', 'price': 138.70, 'code': 'SDS'}},
|
||
)
|
||
p = (prices or {}).get('10:01', {})
|
||
monkeypatch.setattr(
|
||
app_module.eurostar_scraper,
|
||
'fetch',
|
||
lambda destination, travel_date: [
|
||
{
|
||
'depart_st_pancras': '10:01',
|
||
'arrive_destination': '13:34',
|
||
'destination': destination,
|
||
'train_number': 'ES 9014',
|
||
'price': p.get('price') if isinstance(p, dict) else None,
|
||
'seats': p.get('seats') if isinstance(p, dict) else None,
|
||
},
|
||
],
|
||
)
|
||
|
||
|
||
def test_index_shows_station_dropdown_and_destination_radios():
|
||
client = _client()
|
||
|
||
resp = client.get('/')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert 'Departure point' in html
|
||
assert 'Bristol Temple Meads' in html
|
||
assert 'name="station_crs"' in html
|
||
assert html.count('type="radio"') == len(app_module.DESTINATIONS)
|
||
assert 'destination-rotterdam' in html
|
||
|
||
|
||
def test_search_redirects_to_results_with_selected_params():
|
||
client = _client()
|
||
|
||
resp = client.get('/search?destination=rotterdam&travel_date=2026-04-10&min_connection=60&max_connection=120&station_crs=BRI')
|
||
|
||
assert resp.status_code == 302
|
||
assert resp.headers['Location'].endswith(
|
||
'/results/BRI/rotterdam/2026-04-10?min_connection=60&max_connection=120'
|
||
)
|
||
|
||
|
||
def test_results_shows_same_day_destination_switcher(monkeypatch):
|
||
_stub_data(monkeypatch)
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/paris/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert 'Switch destination for Friday 10 April 2026' in html
|
||
assert '<span class="chip-current">Paris Gare du Nord</span>' in html
|
||
assert '/results/BRI/brussels/2026-04-10?min_connection=60&max_connection=120' in html
|
||
assert '/results/BRI/rotterdam/2026-04-10?min_connection=60&max_connection=120' in html
|
||
assert 'ES 9014' in html
|
||
|
||
|
||
def test_results_title_and_social_meta_include_destination(monkeypatch):
|
||
_stub_data(monkeypatch)
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/lille/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert '<title>Bristol Temple Meads to Lille Europe via Eurostar</title>' in html
|
||
assert '<meta property="og:title" content="Bristol Temple Meads to Lille Europe via Eurostar">' in html
|
||
assert (
|
||
'<meta property="og:description" content="Train options from Bristol Temple Meads '
|
||
'to Lille Europe on Friday 10 April 2026 via Paddington, St Pancras, and Eurostar.">'
|
||
) in html
|
||
assert '<meta property="og:url" content="http://localhost/results/BRI/lille/2026-04-10?min_connection=60&max_connection=120">' in html
|
||
|
||
|
||
def test_results_marks_trips_within_five_minutes_of_fastest_and_slowest(monkeypatch):
|
||
monkeypatch.setattr(app_module, 'get_cached', lambda key, ttl=None: None)
|
||
monkeypatch.setattr(app_module, 'set_cached', lambda key, data: None)
|
||
monkeypatch.setattr(app_module.gwr_fares_scraper, 'fetch', lambda s, d: {})
|
||
monkeypatch.setattr(
|
||
app_module.rtt_scraper,
|
||
'fetch',
|
||
lambda travel_date, user_agent, station_crs='BRI': [
|
||
{'depart_bristol': '07:00', 'arrive_paddington': '08:30', 'headcode': '1A01'},
|
||
{'depart_bristol': '07:05', 'arrive_paddington': '08:36', 'headcode': '1A02'},
|
||
{'depart_bristol': '07:10', 'arrive_paddington': '08:46', 'headcode': '1A03'},
|
||
{'depart_bristol': '07:15', 'arrive_paddington': '08:56', 'headcode': '1A04'},
|
||
{'depart_bristol': '07:20', 'arrive_paddington': '09:06', 'headcode': '1A05'},
|
||
],
|
||
)
|
||
monkeypatch.setattr(
|
||
app_module.eurostar_scraper,
|
||
'fetch',
|
||
lambda destination, travel_date: [
|
||
{'depart_st_pancras': '09:30', 'arrive_destination': '11:50', 'destination': destination, 'train_number': 'ES 1001', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '09:40', 'arrive_destination': '12:00', 'destination': destination, 'train_number': 'ES 1002', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '09:50', 'arrive_destination': '12:20', 'destination': destination, 'train_number': 'ES 1003', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '10:00', 'arrive_destination': '12:35', 'destination': destination, 'train_number': 'ES 1004', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '10:10', 'arrive_destination': '12:45', 'destination': destination, 'train_number': 'ES 1005', 'price': None, 'seats': None},
|
||
],
|
||
)
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/paris/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert html.count('title="Fastest journey"') == 2
|
||
assert html.count('title="Slowest journey"') == 2
|
||
assert '4h 50m ⚡' in html
|
||
assert '4h 55m ⚡' in html
|
||
assert '5h 20m 🐢' in html
|
||
assert '5h 25m 🐢' in html
|
||
assert '5h 10m ⚡' not in html
|
||
assert '5h 10m 🐢' not in html
|
||
|
||
|
||
def test_results_shows_only_pre_first_reachable_unreachable_services(monkeypatch):
|
||
# GWR arrives 08:45; min=60 → earliest viable Eurostar 09:45; max=120 → latest 10:45.
|
||
# 09:30 too early → shown as "Too early"
|
||
# 10:15 reachable → shown as a trip (needs circle line XML, so not tested here)
|
||
# 12:30 after first reachable → hidden
|
||
monkeypatch.setattr(app_module, 'get_cached', lambda key, ttl=None: None)
|
||
monkeypatch.setattr(app_module, 'set_cached', lambda key, data: None)
|
||
monkeypatch.setattr(app_module.gwr_fares_scraper, 'fetch', lambda s, d: {})
|
||
monkeypatch.setattr(
|
||
app_module.rtt_scraper,
|
||
'fetch',
|
||
lambda travel_date, user_agent, station_crs='BRI': [
|
||
{'depart_bristol': '07:00', 'arrive_paddington': '08:45', 'headcode': '1A23'},
|
||
],
|
||
)
|
||
monkeypatch.setattr(
|
||
app_module.eurostar_scraper,
|
||
'fetch',
|
||
lambda destination, travel_date: [
|
||
{'depart_st_pancras': '09:30', 'arrive_destination': '12:00', 'destination': destination, 'train_number': 'ES 9001', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '10:15', 'arrive_destination': '13:40', 'destination': destination, 'train_number': 'ES 9002', 'price': None, 'seats': None},
|
||
{'depart_st_pancras': '12:30', 'arrive_destination': '15:55', 'destination': destination, 'train_number': 'ES 9003', 'price': None, 'seats': None},
|
||
],
|
||
)
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/paris/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert 'ES 9001' in html # before first reachable → shown
|
||
assert 'Too early' in html
|
||
assert 'ES 9003' not in html # after first reachable → hidden
|
||
|
||
|
||
def test_results_shows_eurostar_price_and_total(monkeypatch):
|
||
# 07:00 on Friday 2026-04-10 → Anytime £138.70 (weekday, 05:05–08:25 window)
|
||
_stub_data(monkeypatch, prices={'10:01': {'price': 59, 'seats': 42}})
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/paris/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert '£59' in html # Eurostar Standard price
|
||
assert '£197.70' in html # Anytime £138.70 + ES £59
|
||
|
||
|
||
def test_results_shows_unreachable_service_when_no_trips(monkeypatch):
|
||
# Only one Eurostar at 09:30; GWR arrives 08:45 with min=60 → unreachable.
|
||
# No trips at all, so the unreachable service is shown as "Too early".
|
||
monkeypatch.setattr(app_module, 'get_cached', lambda key, ttl=None: None)
|
||
monkeypatch.setattr(app_module, 'set_cached', lambda key, data: None)
|
||
monkeypatch.setattr(app_module.gwr_fares_scraper, 'fetch', lambda s, d: {})
|
||
monkeypatch.setattr(
|
||
app_module.rtt_scraper,
|
||
'fetch',
|
||
lambda travel_date, user_agent, station_crs='BRI': [
|
||
{'depart_bristol': '07:00', 'arrive_paddington': '08:45', 'headcode': '1A23'},
|
||
],
|
||
)
|
||
monkeypatch.setattr(
|
||
app_module.eurostar_scraper,
|
||
'fetch',
|
||
lambda destination, travel_date: [
|
||
{'depart_st_pancras': '09:30', 'arrive_destination': '12:00', 'destination': destination, 'train_number': 'ES 9001', 'price': None, 'seats': None},
|
||
],
|
||
)
|
||
client = _client()
|
||
|
||
resp = client.get('/results/BRI/paris/2026-04-10?min_connection=60&max_connection=120')
|
||
html = resp.get_data(as_text=True)
|
||
|
||
assert resp.status_code == 200
|
||
assert 'ES 9001' in html
|
||
assert 'Too early' in html
|
||
assert 'No valid journeys found.' not in html
|