edward/depicts
1
0
Fork 0
Code Issues 8 Pull requests Packages Projects Releases Wiki Activity

CatalogDict: institution and URL can be None

Browse source
This commit is contained in:
Edward Betts 2023-11-09 07:37:28 +01:00
parent f33f4b6394
commit ae0b2e5a51
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
depicts/type.py
View file

@ -28,8 +28,8 @@ class Entity(TypedDict, total=False):
class CatalogDict(TypedDict, total=False): class CatalogDict(TypedDict, total=False):
"""Catalog record from institution web site.""" """Catalog record from institution web site."""
institution: str institution: str | None
url: str url: str | None
ids: set[str] ids: set[str]
detail: list[dict[str, str]] detail: list[dict[str, str]]
description: str description: str

1
depicts/wd_catalog.py
View file

@ -399,7 +399,6 @@ def get_catalog_from_artwork(entity: Entity) -> CatalogDict:
catalog_detail.append(detail) catalog_detail.append(detail)
url = wikibase.first_datavalue(entity, "P973") url = wikibase.first_datavalue(entity, "P973")
assert isinstance(url, str)
catalog: CatalogDict = { catalog: CatalogDict = {
"url": url, "url": url,
"detail": catalog_detail, "detail": catalog_detail,