Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
52 lines
1.8 KiB
TypeScript
52 lines
1.8 KiB
TypeScript
import type {CodeKeywordDefinition} from "../../types"
|
|
import type {KeywordCxt} from "../../compile/validate"
|
|
import {_, getProperty, Code, Name} from "../../compile/codegen"
|
|
import N from "../../compile/names"
|
|
import {callRef} from "../core/ref"
|
|
|
|
const def: CodeKeywordDefinition = {
|
|
keyword: "$dynamicRef",
|
|
schemaType: "string",
|
|
code: (cxt) => dynamicRef(cxt, cxt.schema),
|
|
}
|
|
|
|
export function dynamicRef(cxt: KeywordCxt, ref: string): void {
|
|
const {gen, keyword, it} = cxt
|
|
if (ref[0] !== "#") throw new Error(`"${keyword}" only supports hash fragment reference`)
|
|
const anchor = ref.slice(1)
|
|
if (it.allErrors) {
|
|
_dynamicRef()
|
|
} else {
|
|
const valid = gen.let("valid", false)
|
|
_dynamicRef(valid)
|
|
cxt.ok(valid)
|
|
}
|
|
|
|
function _dynamicRef(valid?: Name): void {
|
|
// TODO the assumption here is that `recursiveRef: #` always points to the root
|
|
// of the schema object, which is not correct, because there may be $id that
|
|
// makes # point to it, and the target schema may not contain dynamic/recursiveAnchor.
|
|
// Because of that 2 tests in recursiveRef.json fail.
|
|
// This is a similar problem to #815 (`$id` doesn't alter resolution scope for `{ "$ref": "#" }`).
|
|
// (This problem is not tested in JSON-Schema-Test-Suite)
|
|
if (it.schemaEnv.root.dynamicAnchors[anchor]) {
|
|
const v = gen.let("_v", _`${N.dynamicAnchors}${getProperty(anchor)}`)
|
|
gen.if(v, _callRef(v, valid), _callRef(it.validateName, valid))
|
|
} else {
|
|
_callRef(it.validateName, valid)()
|
|
}
|
|
}
|
|
|
|
function _callRef(validate: Code, valid?: Name): () => void {
|
|
return valid
|
|
? () =>
|
|
gen.block(() => {
|
|
callRef(cxt, validate)
|
|
gen.let(valid, true)
|
|
})
|
|
: () => callRef(cxt, validate)
|
|
}
|
|
}
|
|
|
|
export default def
|