Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
98 lines
2.8 KiB
JavaScript
98 lines
2.8 KiB
JavaScript
/**
|
|
* @fileoverview require default case in switch statements
|
|
* @author Aliaksei Shytkin
|
|
*/
|
|
"use strict";
|
|
|
|
const DEFAULT_COMMENT_PATTERN = /^no default$/iu;
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Require `default` cases in `switch` statements",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/default-case"
|
|
},
|
|
|
|
schema: [{
|
|
type: "object",
|
|
properties: {
|
|
commentPattern: {
|
|
type: "string"
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}],
|
|
|
|
messages: {
|
|
missingDefaultCase: "Expected a default case."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const options = context.options[0] || {};
|
|
const commentPattern = options.commentPattern
|
|
? new RegExp(options.commentPattern, "u")
|
|
: DEFAULT_COMMENT_PATTERN;
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Shortcut to get last element of array
|
|
* @param {*[]} collection Array
|
|
* @returns {any} Last element
|
|
*/
|
|
function last(collection) {
|
|
return collection.at(-1);
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
SwitchStatement(node) {
|
|
|
|
if (!node.cases.length) {
|
|
|
|
/*
|
|
* skip check of empty switch because there is no easy way
|
|
* to extract comments inside it now
|
|
*/
|
|
return;
|
|
}
|
|
|
|
const hasDefault = node.cases.some(v => v.test === null);
|
|
|
|
if (!hasDefault) {
|
|
|
|
let comment;
|
|
|
|
const lastCase = last(node.cases);
|
|
const comments = sourceCode.getCommentsAfter(lastCase);
|
|
|
|
if (comments.length) {
|
|
comment = last(comments);
|
|
}
|
|
|
|
if (!comment || !commentPattern.test(comment.value.trim())) {
|
|
context.report({ node, messageId: "missingDefaultCase" });
|
|
}
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|