Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
/**
|
|
* @fileoverview enforce default parameters to be last
|
|
* @author Chiawen Chen
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Enforce default parameters to be last",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/default-param-last"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
shouldBeLast: "Default parameters should be last."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/**
|
|
* Handler for function contexts.
|
|
* @param {ASTNode} node function node
|
|
* @returns {void}
|
|
*/
|
|
function handleFunction(node) {
|
|
let hasSeenPlainParam = false;
|
|
|
|
for (let i = node.params.length - 1; i >= 0; i -= 1) {
|
|
const param = node.params[i];
|
|
|
|
if (
|
|
param.type !== "AssignmentPattern" &&
|
|
param.type !== "RestElement"
|
|
) {
|
|
hasSeenPlainParam = true;
|
|
continue;
|
|
}
|
|
|
|
if (hasSeenPlainParam && param.type === "AssignmentPattern") {
|
|
context.report({
|
|
node: param,
|
|
messageId: "shouldBeLast"
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: handleFunction,
|
|
FunctionExpression: handleFunction,
|
|
ArrowFunctionExpression: handleFunction
|
|
};
|
|
}
|
|
};
|