Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
109 lines
3.4 KiB
JavaScript
109 lines
3.4 KiB
JavaScript
/**
|
|
* @fileoverview Validates newlines before and after dots
|
|
* @author Greg Cochard
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce consistent newlines before and after dots",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/dot-location"
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
enum: ["object", "property"]
|
|
}
|
|
],
|
|
|
|
fixable: "code",
|
|
|
|
messages: {
|
|
expectedDotAfterObject: "Expected dot to be on same line as object.",
|
|
expectedDotBeforeProperty: "Expected dot to be on same line as property."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const config = context.options[0];
|
|
|
|
// default to onObject if no preference is passed
|
|
const onObject = config === "object" || !config;
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Reports if the dot between object and property is on the correct location.
|
|
* @param {ASTNode} node The `MemberExpression` node.
|
|
* @returns {void}
|
|
*/
|
|
function checkDotLocation(node) {
|
|
const property = node.property;
|
|
const dotToken = sourceCode.getTokenBefore(property);
|
|
|
|
if (onObject) {
|
|
|
|
// `obj` expression can be parenthesized, but those paren tokens are not a part of the `obj` node.
|
|
const tokenBeforeDot = sourceCode.getTokenBefore(dotToken);
|
|
|
|
if (!astUtils.isTokenOnSameLine(tokenBeforeDot, dotToken)) {
|
|
context.report({
|
|
node,
|
|
loc: dotToken.loc,
|
|
messageId: "expectedDotAfterObject",
|
|
*fix(fixer) {
|
|
if (dotToken.value.startsWith(".") && astUtils.isDecimalIntegerNumericToken(tokenBeforeDot)) {
|
|
yield fixer.insertTextAfter(tokenBeforeDot, ` ${dotToken.value}`);
|
|
} else {
|
|
yield fixer.insertTextAfter(tokenBeforeDot, dotToken.value);
|
|
}
|
|
yield fixer.remove(dotToken);
|
|
}
|
|
});
|
|
}
|
|
} else if (!astUtils.isTokenOnSameLine(dotToken, property)) {
|
|
context.report({
|
|
node,
|
|
loc: dotToken.loc,
|
|
messageId: "expectedDotBeforeProperty",
|
|
*fix(fixer) {
|
|
yield fixer.remove(dotToken);
|
|
yield fixer.insertTextBefore(property, dotToken.value);
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Checks the spacing of the dot within a member expression.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkNode(node) {
|
|
if (!node.computed) {
|
|
checkDotLocation(node);
|
|
}
|
|
}
|
|
|
|
return {
|
|
MemberExpression: checkNode
|
|
};
|
|
}
|
|
};
|