Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
85 lines
2.9 KiB
JavaScript
85 lines
2.9 KiB
JavaScript
/**
|
|
* @fileoverview enforce the location of arrow function bodies
|
|
* @author Sharmila Jesupaul
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
const { isCommentToken, isNotOpeningParenToken } = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "layout",
|
|
|
|
docs: {
|
|
description: "Enforce the location of arrow function bodies",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/implicit-arrow-linebreak"
|
|
},
|
|
|
|
fixable: "whitespace",
|
|
|
|
schema: [
|
|
{
|
|
enum: ["beside", "below"]
|
|
}
|
|
],
|
|
messages: {
|
|
expected: "Expected a linebreak before this expression.",
|
|
unexpected: "Expected no linebreak before this expression."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
const option = context.options[0] || "beside";
|
|
|
|
/**
|
|
* Validates the location of an arrow function body
|
|
* @param {ASTNode} node The arrow function body
|
|
* @returns {void}
|
|
*/
|
|
function validateExpression(node) {
|
|
if (node.body.type === "BlockStatement") {
|
|
return;
|
|
}
|
|
|
|
const arrowToken = sourceCode.getTokenBefore(node.body, isNotOpeningParenToken);
|
|
const firstTokenOfBody = sourceCode.getTokenAfter(arrowToken);
|
|
|
|
if (arrowToken.loc.end.line === firstTokenOfBody.loc.start.line && option === "below") {
|
|
context.report({
|
|
node: firstTokenOfBody,
|
|
messageId: "expected",
|
|
fix: fixer => fixer.insertTextBefore(firstTokenOfBody, "\n")
|
|
});
|
|
} else if (arrowToken.loc.end.line !== firstTokenOfBody.loc.start.line && option === "beside") {
|
|
context.report({
|
|
node: firstTokenOfBody,
|
|
messageId: "unexpected",
|
|
fix(fixer) {
|
|
if (sourceCode.getFirstTokenBetween(arrowToken, firstTokenOfBody, { includeComments: true, filter: isCommentToken })) {
|
|
return null;
|
|
}
|
|
|
|
return fixer.replaceTextRange([arrowToken.range[1], firstTokenOfBody.range[0]], " ");
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
//----------------------------------------------------------------------
|
|
// Public
|
|
//----------------------------------------------------------------------
|
|
return {
|
|
ArrowFunctionExpression: node => validateExpression(node)
|
|
};
|
|
}
|
|
};
|