Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
77 lines
2.4 KiB
JavaScript
77 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of an lexical declarations inside a case clause
|
|
* @author Erik Arvidsson
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow lexical declarations in case clauses",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-case-declarations"
|
|
},
|
|
|
|
hasSuggestions: true,
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
addBrackets: "Add {} brackets around the case block.",
|
|
unexpected: "Unexpected lexical declaration in case block."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
/**
|
|
* Checks whether or not a node is a lexical declaration.
|
|
* @param {ASTNode} node A direct child statement of a switch case.
|
|
* @returns {boolean} Whether or not the node is a lexical declaration.
|
|
*/
|
|
function isLexicalDeclaration(node) {
|
|
switch (node.type) {
|
|
case "FunctionDeclaration":
|
|
case "ClassDeclaration":
|
|
return true;
|
|
case "VariableDeclaration":
|
|
return node.kind !== "var";
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return {
|
|
SwitchCase(node) {
|
|
for (let i = 0; i < node.consequent.length; i++) {
|
|
const statement = node.consequent[i];
|
|
|
|
if (isLexicalDeclaration(statement)) {
|
|
context.report({
|
|
node: statement,
|
|
messageId: "unexpected",
|
|
suggest: [
|
|
{
|
|
messageId: "addBrackets",
|
|
fix: fixer => [
|
|
fixer.insertTextBefore(node.consequent[0], "{ "),
|
|
fixer.insertTextAfter(node.consequent.at(-1), " }")
|
|
]
|
|
}
|
|
]
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|