Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
83 lines
2.4 KiB
JavaScript
83 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag duplicate arguments
|
|
* @author Jamund Ferguson
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Disallow duplicate arguments in `function` definitions",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-dupe-args"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unexpected: "Duplicate param '{{name}}'."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks whether or not a given definition is a parameter's.
|
|
* @param {eslint-scope.DefEntry} def A definition to check.
|
|
* @returns {boolean} `true` if the definition is a parameter's.
|
|
*/
|
|
function isParameter(def) {
|
|
return def.type === "Parameter";
|
|
}
|
|
|
|
/**
|
|
* Determines if a given node has duplicate parameters.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkParams(node) {
|
|
const variables = sourceCode.getDeclaredVariables(node);
|
|
|
|
for (let i = 0; i < variables.length; ++i) {
|
|
const variable = variables[i];
|
|
|
|
// Checks and reports duplications.
|
|
const defs = variable.defs.filter(isParameter);
|
|
|
|
if (defs.length >= 2) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpected",
|
|
data: { name: variable.name }
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
FunctionDeclaration: checkParams,
|
|
FunctionExpression: checkParams
|
|
};
|
|
|
|
}
|
|
};
|