Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
81 lines
2.4 KiB
JavaScript
81 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag labels that are the same as an identifier
|
|
* @author Ian Christian Myers
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow labels that share a name with a variable",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-label-var"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
identifierClashWithLabel: "Found identifier with same name as label."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Check if the identifier is present inside current scope
|
|
* @param {Object} scope current scope
|
|
* @param {string} name To evaluate
|
|
* @returns {boolean} True if its present
|
|
* @private
|
|
*/
|
|
function findIdentifier(scope, name) {
|
|
return astUtils.getVariableByName(scope, name) !== null;
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public API
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
|
|
LabeledStatement(node) {
|
|
|
|
// Fetch the innermost scope.
|
|
const scope = sourceCode.getScope(node);
|
|
|
|
/*
|
|
* Recursively find the identifier walking up the scope, starting
|
|
* with the innermost scope.
|
|
*/
|
|
if (findIdentifier(scope, node.label.name)) {
|
|
context.report({
|
|
node,
|
|
messageId: "identifierClashWithLabel"
|
|
});
|
|
}
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
};
|