Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
99 lines
3 KiB
JavaScript
99 lines
3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow assignments to native objects or read-only global variables
|
|
* @author Ilya Volodin
|
|
* @deprecated in ESLint v3.3.0
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow assignments to native objects or read-only global variables",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-native-reassign"
|
|
},
|
|
|
|
deprecated: true,
|
|
|
|
replacedBy: ["no-global-assign"],
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
exceptions: {
|
|
type: "array",
|
|
items: { type: "string" },
|
|
uniqueItems: true
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
nativeReassign: "Read-only global '{{name}}' should not be modified."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const config = context.options[0];
|
|
const exceptions = (config && config.exceptions) || [];
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Reports write references.
|
|
* @param {Reference} reference A reference to check.
|
|
* @param {int} index The index of the reference in the references.
|
|
* @param {Reference[]} references The array that the reference belongs to.
|
|
* @returns {void}
|
|
*/
|
|
function checkReference(reference, index, references) {
|
|
const identifier = reference.identifier;
|
|
|
|
if (reference.init === false &&
|
|
reference.isWrite() &&
|
|
|
|
/*
|
|
* Destructuring assignments can have multiple default value,
|
|
* so possibly there are multiple writeable references for the same identifier.
|
|
*/
|
|
(index === 0 || references[index - 1].identifier !== identifier)
|
|
) {
|
|
context.report({
|
|
node: identifier,
|
|
messageId: "nativeReassign",
|
|
data: identifier
|
|
});
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Reports write references if a given variable is read-only builtin.
|
|
* @param {Variable} variable A variable to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkVariable(variable) {
|
|
if (variable.writeable === false && !exceptions.includes(variable.name)) {
|
|
variable.references.forEach(checkReference);
|
|
}
|
|
}
|
|
|
|
return {
|
|
Program(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
|
|
globalScope.variables.forEach(checkVariable);
|
|
}
|
|
};
|
|
}
|
|
};
|