Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
88 lines
3 KiB
JavaScript
88 lines
3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag when using new Function
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const astUtils = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
const callMethods = new Set(["apply", "bind", "call"]);
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow `new` operators with the `Function` object",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-new-func"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
noFunctionConstructor: "The Function constructor is eval."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const sourceCode = context.sourceCode;
|
|
|
|
return {
|
|
"Program:exit"(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
const variable = globalScope.set.get("Function");
|
|
|
|
if (variable && variable.defs.length === 0) {
|
|
variable.references.forEach(ref => {
|
|
const idNode = ref.identifier;
|
|
const { parent } = idNode;
|
|
let evalNode;
|
|
|
|
if (parent) {
|
|
if (idNode === parent.callee && (
|
|
parent.type === "NewExpression" ||
|
|
parent.type === "CallExpression"
|
|
)) {
|
|
evalNode = parent;
|
|
} else if (
|
|
parent.type === "MemberExpression" &&
|
|
idNode === parent.object &&
|
|
callMethods.has(astUtils.getStaticPropertyName(parent))
|
|
) {
|
|
const maybeCallee = parent.parent.type === "ChainExpression" ? parent.parent : parent;
|
|
|
|
if (maybeCallee.parent.type === "CallExpression" && maybeCallee.parent.callee === maybeCallee) {
|
|
evalNode = maybeCallee.parent;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (evalNode) {
|
|
context.report({
|
|
node: evalNode,
|
|
messageId: "noFunctionConstructor"
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|