Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
67 lines
2.1 KiB
JavaScript
67 lines
2.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to disallow use of the new operator with global non-constructor functions
|
|
* @author Sosuke Suzuki
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
const nonConstructorGlobalFunctionNames = ["Symbol", "BigInt"];
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Disallow `new` operators with global non-constructor functions",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-new-native-nonconstructor"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
noNewNonconstructor: "`{{name}}` cannot be called as a constructor."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
return {
|
|
"Program:exit"(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
|
|
for (const nonConstructorName of nonConstructorGlobalFunctionNames) {
|
|
const variable = globalScope.set.get(nonConstructorName);
|
|
|
|
if (variable && variable.defs.length === 0) {
|
|
variable.references.forEach(ref => {
|
|
const idNode = ref.identifier;
|
|
const parent = idNode.parent;
|
|
|
|
if (parent && parent.type === "NewExpression" && parent.callee === idNode) {
|
|
context.report({
|
|
node: idNode,
|
|
messageId: "noNewNonconstructor",
|
|
data: { name: nonConstructorName }
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|