Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
61 lines
1.7 KiB
JavaScript
61 lines
1.7 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag when using constructor for wrapper objects
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Requirements
|
|
//------------------------------------------------------------------------------
|
|
|
|
const { getVariableByName } = require("./utils/ast-utils");
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow `new` operators with the `String`, `Number`, and `Boolean` objects",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-new-wrappers"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
noConstructor: "Do not use {{fn}} as a constructor."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const { sourceCode } = context;
|
|
|
|
return {
|
|
|
|
NewExpression(node) {
|
|
const wrapperObjects = ["String", "Number", "Boolean"];
|
|
const { name } = node.callee;
|
|
|
|
if (wrapperObjects.includes(name)) {
|
|
const variable = getVariableByName(sourceCode.getScope(node), name);
|
|
|
|
if (variable && variable.identifiers.length === 0) {
|
|
context.report({
|
|
node,
|
|
messageId: "noConstructor",
|
|
data: { fn: name }
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|