Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
106 lines
3.1 KiB
JavaScript
106 lines
3.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag use of unary increment and decrement operators.
|
|
* @author Ian Christian Myers
|
|
* @author Brody McKee (github.com/mrmckeb)
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Determines whether the given node is the update node of a `ForStatement`.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {boolean} `true` if the node is `ForStatement` update.
|
|
*/
|
|
function isForStatementUpdate(node) {
|
|
const parent = node.parent;
|
|
|
|
return parent.type === "ForStatement" && parent.update === node;
|
|
}
|
|
|
|
/**
|
|
* Determines whether the given node is considered to be a for loop "afterthought" by the logic of this rule.
|
|
* In particular, it returns `true` if the given node is either:
|
|
* - The update node of a `ForStatement`: for (;; i++) {}
|
|
* - An operand of a sequence expression that is the update node: for (;; foo(), i++) {}
|
|
* - An operand of a sequence expression that is child of another sequence expression, etc.,
|
|
* up to the sequence expression that is the update node: for (;; foo(), (bar(), (baz(), i++))) {}
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {boolean} `true` if the node is a for loop afterthought.
|
|
*/
|
|
function isForLoopAfterthought(node) {
|
|
const parent = node.parent;
|
|
|
|
if (parent.type === "SequenceExpression") {
|
|
return isForLoopAfterthought(parent);
|
|
}
|
|
|
|
return isForStatementUpdate(node);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow the unary operators `++` and `--`",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-plusplus"
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
allowForLoopAfterthoughts: {
|
|
type: "boolean",
|
|
default: false
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
|
|
messages: {
|
|
unexpectedUnaryOp: "Unary operator '{{operator}}' used."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const config = context.options[0];
|
|
let allowForLoopAfterthoughts = false;
|
|
|
|
if (typeof config === "object") {
|
|
allowForLoopAfterthoughts = config.allowForLoopAfterthoughts === true;
|
|
}
|
|
|
|
return {
|
|
|
|
UpdateExpression(node) {
|
|
if (allowForLoopAfterthoughts && isForLoopAfterthought(node)) {
|
|
return;
|
|
}
|
|
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedUnaryOp",
|
|
data: {
|
|
operator: node.operator
|
|
}
|
|
});
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
};
|