Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
66 lines
2.2 KiB
JavaScript
66 lines
2.2 KiB
JavaScript
/**
|
|
* @fileoverview Disallow shadowing of NaN, undefined, and Infinity (ES5 section 15.1.1)
|
|
* @author Michael Ficarra
|
|
*/
|
|
"use strict";
|
|
|
|
/**
|
|
* Determines if a variable safely shadows undefined.
|
|
* This is the case when a variable named `undefined` is never assigned to a value (i.e. it always shares the same value
|
|
* as the global).
|
|
* @param {eslintScope.Variable} variable The variable to check
|
|
* @returns {boolean} true if this variable safely shadows `undefined`
|
|
*/
|
|
function safelyShadowsUndefined(variable) {
|
|
return variable.name === "undefined" &&
|
|
variable.references.every(ref => !ref.isWrite()) &&
|
|
variable.defs.every(def => def.node.type === "VariableDeclarator" && def.node.init === null);
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow identifiers from shadowing restricted names",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-shadow-restricted-names"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
shadowingRestrictedName: "Shadowing of global property '{{name}}'."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
|
|
const RESTRICTED = new Set(["undefined", "NaN", "Infinity", "arguments", "eval"]);
|
|
const sourceCode = context.sourceCode;
|
|
|
|
return {
|
|
"VariableDeclaration, :function, CatchClause"(node) {
|
|
for (const variable of sourceCode.getDeclaredVariables(node)) {
|
|
if (variable.defs.length > 0 && RESTRICTED.has(variable.name) && !safelyShadowsUndefined(variable)) {
|
|
context.report({
|
|
node: variable.defs[0].name,
|
|
messageId: "shadowingRestrictedName",
|
|
data: {
|
|
name: variable.name
|
|
}
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|