Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
80 lines
2.3 KiB
JavaScript
80 lines
2.3 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag references to undeclared variables.
|
|
* @author Mark Macdonald
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Helpers
|
|
//------------------------------------------------------------------------------
|
|
|
|
/**
|
|
* Checks if the given node is the argument of a typeof operator.
|
|
* @param {ASTNode} node The AST node being checked.
|
|
* @returns {boolean} Whether or not the node is the argument of a typeof operator.
|
|
*/
|
|
function hasTypeOfOperator(node) {
|
|
const parent = node.parent;
|
|
|
|
return parent.type === "UnaryExpression" && parent.operator === "typeof";
|
|
}
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "problem",
|
|
|
|
docs: {
|
|
description: "Disallow the use of undeclared variables unless mentioned in `/*global */` comments",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-undef"
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
typeof: {
|
|
type: "boolean",
|
|
default: false
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
],
|
|
messages: {
|
|
undef: "'{{name}}' is not defined."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const options = context.options[0];
|
|
const considerTypeOf = options && options.typeof === true || false;
|
|
const sourceCode = context.sourceCode;
|
|
|
|
return {
|
|
"Program:exit"(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
|
|
globalScope.through.forEach(ref => {
|
|
const identifier = ref.identifier;
|
|
|
|
if (!considerTypeOf && hasTypeOfOperator(identifier)) {
|
|
return;
|
|
}
|
|
|
|
context.report({
|
|
node: identifier,
|
|
messageId: "undef",
|
|
data: identifier
|
|
});
|
|
});
|
|
}
|
|
};
|
|
}
|
|
};
|