Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
87 lines
2.2 KiB
JavaScript
87 lines
2.2 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag references to the undefined variable.
|
|
* @author Michael Ficarra
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow the use of `undefined` as an identifier",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/no-undefined"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unexpectedUndefined: "Unexpected use of undefined."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const sourceCode = context.sourceCode;
|
|
|
|
/**
|
|
* Report an invalid "undefined" identifier node.
|
|
* @param {ASTNode} node The node to report.
|
|
* @returns {void}
|
|
*/
|
|
function report(node) {
|
|
context.report({
|
|
node,
|
|
messageId: "unexpectedUndefined"
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Checks the given scope for references to `undefined` and reports
|
|
* all references found.
|
|
* @param {eslint-scope.Scope} scope The scope to check.
|
|
* @returns {void}
|
|
*/
|
|
function checkScope(scope) {
|
|
const undefinedVar = scope.set.get("undefined");
|
|
|
|
if (!undefinedVar) {
|
|
return;
|
|
}
|
|
|
|
const references = undefinedVar.references;
|
|
|
|
const defs = undefinedVar.defs;
|
|
|
|
// Report non-initializing references (those are covered in defs below)
|
|
references
|
|
.filter(ref => !ref.init)
|
|
.forEach(ref => report(ref.identifier));
|
|
|
|
defs.forEach(def => report(def.name));
|
|
}
|
|
|
|
return {
|
|
"Program:exit"(node) {
|
|
const globalScope = sourceCode.getScope(node);
|
|
|
|
const stack = [globalScope];
|
|
|
|
while (stack.length) {
|
|
const scope = stack.pop();
|
|
|
|
stack.push(...scope.childScopes);
|
|
checkScope(scope);
|
|
}
|
|
}
|
|
};
|
|
|
|
}
|
|
};
|