Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
/**
|
|
* @fileoverview Reports useless `catch` clauses that just rethrow their error.
|
|
* @author Teddy Katz
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Disallow unnecessary `catch` clauses",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/no-useless-catch"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
unnecessaryCatchClause: "Unnecessary catch clause.",
|
|
unnecessaryCatch: "Unnecessary try/catch wrapper."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
return {
|
|
CatchClause(node) {
|
|
if (
|
|
node.param &&
|
|
node.param.type === "Identifier" &&
|
|
node.body.body.length &&
|
|
node.body.body[0].type === "ThrowStatement" &&
|
|
node.body.body[0].argument.type === "Identifier" &&
|
|
node.body.body[0].argument.name === node.param.name
|
|
) {
|
|
if (node.parent.finalizer) {
|
|
context.report({
|
|
node,
|
|
messageId: "unnecessaryCatchClause"
|
|
});
|
|
} else {
|
|
context.report({
|
|
node: node.parent,
|
|
messageId: "unnecessaryCatch"
|
|
});
|
|
}
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|