Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
96 lines
2.9 KiB
JavaScript
96 lines
2.9 KiB
JavaScript
/**
|
|
* @fileoverview Rule to check multiple var declarations per line
|
|
* @author Alberto Rodríguez
|
|
* @deprecated in ESLint v8.53.0
|
|
*/
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
deprecated: true,
|
|
replacedBy: [],
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Require or disallow newlines around variable declarations",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/latest/rules/one-var-declaration-per-line"
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
enum: ["always", "initializations"]
|
|
}
|
|
],
|
|
|
|
fixable: "whitespace",
|
|
|
|
messages: {
|
|
expectVarOnNewline: "Expected variable declaration to be on a new line."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const always = context.options[0] === "always";
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Helpers
|
|
//--------------------------------------------------------------------------
|
|
|
|
|
|
/**
|
|
* Determine if provided keyword is a variant of for specifiers
|
|
* @private
|
|
* @param {string} keyword keyword to test
|
|
* @returns {boolean} True if `keyword` is a variant of for specifier
|
|
*/
|
|
function isForTypeSpecifier(keyword) {
|
|
return keyword === "ForStatement" || keyword === "ForInStatement" || keyword === "ForOfStatement";
|
|
}
|
|
|
|
/**
|
|
* Checks newlines around variable declarations.
|
|
* @private
|
|
* @param {ASTNode} node `VariableDeclaration` node to test
|
|
* @returns {void}
|
|
*/
|
|
function checkForNewLine(node) {
|
|
if (isForTypeSpecifier(node.parent.type)) {
|
|
return;
|
|
}
|
|
|
|
const declarations = node.declarations;
|
|
let prev;
|
|
|
|
declarations.forEach(current => {
|
|
if (prev && prev.loc.end.line === current.loc.start.line) {
|
|
if (always || prev.init || current.init) {
|
|
context.report({
|
|
node,
|
|
messageId: "expectVarOnNewline",
|
|
loc: current.loc,
|
|
fix: fixer => fixer.insertTextBefore(current, "\n")
|
|
});
|
|
}
|
|
}
|
|
prev = current;
|
|
});
|
|
}
|
|
|
|
//--------------------------------------------------------------------------
|
|
// Public
|
|
//--------------------------------------------------------------------------
|
|
|
|
return {
|
|
VariableDeclaration: checkForNewLine
|
|
};
|
|
|
|
}
|
|
};
|