Edward Betts
ea4980a5d7
Adjust European short trip heuristic from >3 days to >1 day to correctly detect when user has returned home from European trips. This fixes the April 29-30, 2023 case where the location incorrectly showed "Sankt Georg, Hamburg" instead of "Bristol" when the user was free (no events scheduled) after the foss-north trip ended on April 27. The previous logic required more than 3 days to pass before assuming return home from European countries, but for short European trips by rail/ferry, users typically return within 1-2 days. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
78 lines
2.1 KiB
JavaScript
78 lines
2.1 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag the generator functions that does not have yield.
|
|
* @author Toru Nagashima
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
/** @type {import('../shared/types').Rule} */
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "Require generator functions to contain `yield`",
|
|
recommended: true,
|
|
url: "https://eslint.org/docs/latest/rules/require-yield"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
missingYield: "This generator function does not have 'yield'."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
const stack = [];
|
|
|
|
/**
|
|
* If the node is a generator function, start counting `yield` keywords.
|
|
* @param {Node} node A function node to check.
|
|
* @returns {void}
|
|
*/
|
|
function beginChecking(node) {
|
|
if (node.generator) {
|
|
stack.push(0);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* If the node is a generator function, end counting `yield` keywords, then
|
|
* reports result.
|
|
* @param {Node} node A function node to check.
|
|
* @returns {void}
|
|
*/
|
|
function endChecking(node) {
|
|
if (!node.generator) {
|
|
return;
|
|
}
|
|
|
|
const countYield = stack.pop();
|
|
|
|
if (countYield === 0 && node.body.body.length > 0) {
|
|
context.report({ node, messageId: "missingYield" });
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: beginChecking,
|
|
"FunctionDeclaration:exit": endChecking,
|
|
FunctionExpression: beginChecking,
|
|
"FunctionExpression:exit": endChecking,
|
|
|
|
// Increases the count of `yield` keyword.
|
|
YieldExpression() {
|
|
|
|
if (stack.length > 0) {
|
|
stack[stack.length - 1] += 1;
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|